Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RANGER-4942: Fix Dockerfiles of ./build_ranger_using_docker.sh #396

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marco-luzzara
Copy link

What changes were proposed in this pull request?

This PR fixes some syntactic mistakes on the Dockerfiles involved in the Ranger build in a Dockerized environment. The 3 main issues I have fixed are:

  • RUN if [ "${OS_NAME}" == "UBUNTU" ]; then ...: the commands enclosed in this if-condition will never be executed because the shell used for this command is /bin/sh, which requires a single = for string comparison.

  • For some reasons, the ENV JAVA_HOME /usr/lib/... Dockerfile command is placed inside the RUN command. I put it before the RUN command in order to use the JAVA_HOME env variable in the shell script.

  • Many env variables are initialized using the alternative syntax ENV MY_ENV_VAR value1, which is not compliant with the guidelines, that suggests using ENV MY_ENV_VAR=value1. I quote from the ENV reference:

    The alternative syntax is supported for backward compatibility, but discouraged for the reasons outlined above, and may be removed in a future release.

    I rewrote only some of them, in case you preferred another PR for a general Dockerfile/compose improvements.

How was this patch tested?

By running ./build_ranger_using_docker.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant